Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade go.etcd.io/bbolt to fix panic in unit test with go1.14 #2690

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Fix panic in unit test with go >= 1.14. ref: etcd-io/bbolt#201

What is changed and how it works?

Replace etcd-io/bbolt version to the latest one.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has go.mod change

Release note

Upgrade go.etcd.io/bbolt to fix panic in unit test with go1.14.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added type/bugfix This PR fixes a bug. component/misc Some other things. labels Jul 29, 2020
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Jul 29, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 29, 2020
@disksing
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@JmPotato merge failed.

@JmPotato
Copy link
Member Author

/run-integration-common-test

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2020
@JmPotato
Copy link
Member Author

/run-all-tests

@JmPotato JmPotato merged commit 2908a92 into tikv:master Jul 29, 2020
@JmPotato JmPotato deleted the update_etcd branch July 29, 2020 09:02
@HunDunDM HunDunDM added the needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. label Jan 5, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Jan 5, 2021

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Jan 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

HunDunDM added a commit to ti-srebot/pd that referenced this pull request Jan 5, 2021
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Jan 5, 2021
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>

Co-authored-by: Zheng Xiangsheng <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/misc Some other things. contribution This PR is from a community contributor. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants