Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tso: optimize the err handling and make their specification consistent #2878

Merged
merged 4 commits into from
Sep 2, 2020

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Sep 2, 2020

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

This PR does some optimization for the error handling by defining the error when we first meet it in tso.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Related changes

Release note

  • Optimize the err handling in tso pkg.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added require-LGT1 Indicates that the PR requires an LGTM. component/tso Timestamp Oracle. labels Sep 2, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Sep 2, 2020

server/tso/tso.go Outdated Show resolved Hide resolved
server/tso/tso.go Outdated Show resolved Hide resolved
@JmPotato JmPotato changed the title tso: optimize the err handling and and make their specification consistent tso: optimize the err handling and make their specification consistent Sep 2, 2020
Co-authored-by: Howard Lau <howardlau1999@hotmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2020
@JmPotato
Copy link
Member Author

JmPotato commented Sep 2, 2020

/run-all-tests

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2020
@JmPotato
Copy link
Member Author

JmPotato commented Sep 2, 2020

/run-integration-common-test

@JmPotato JmPotato merged commit c7e9ecf into tikv:master Sep 2, 2020
@JmPotato JmPotato deleted the tso_err branch September 2, 2020 05:52
@JmPotato JmPotato added component/log Log. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. labels Sep 4, 2020
@JmPotato
Copy link
Member Author

JmPotato commented Sep 7, 2020

/run-cherry-pick

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Sep 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2910

@JmPotato JmPotato removed the needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. component/tso Timestamp Oracle. require-LGT1 Indicates that the PR requires an LGTM. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants