Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add more metrics for region and store heartbeat (#2881) #2891

Merged
merged 4 commits into from
Sep 7, 2020
Merged

metrics: add more metrics for region and store heartbeat (#2881) #2891

merged 4 commits into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2881 to release-4.0

Signed-off-by: Zheming Li nkdudu@126.com

What problem does this PR solve?

Add more metrics about heartbeat. Solve #2800

What is changed and how it works?

  • Add heartbeat handle duration for region heartbeat and store heartbeat.

  • Add panel in pd grafana dashboard.

  • Fix RegionHeartBeat still count "ok" when error occurs.

Check List

Tests

  • Manual test: using tiup to run this pd and import pd.json manually in grafana.

Code changes

  • Has metrics changed.

Release note

  • No release note

@lizhemingi @ti-srebot
cherry pick tikv#2881 to release-4.0
51cfefb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 3, 2020
Merged
@ti-srebot ti-srebot added contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Sep 3, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 3, 2020
@ti-srebot ti-srebot self-assigned this Sep 3, 2020
@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #2891 into release-4.0 will decrease coverage by 0.07%.
The diff coverage is 84.61%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2891      +/-   ##
===============================================
- Coverage        77.51%   77.43%   -0.08%     
===============================================
  Files              210      209       -1     
  Lines            22784    22790       +6     
===============================================
- Hits             17660    17648      -12     
- Misses            3801     3815      +14     
- Partials          1323     1327       +4
Impacted Files Coverage Δ
server/grpc_service.go 59.39% <81.81%> (-1.07%) ⬇️
server/metrics.go 100.00% <100.00%> (ø)
server/heartbeat_streams.go 68.00% <0.00%> (-6.00%) ⬇️
server/kv/etcd_kv.go 84.41% <0.00%> (-3.90%) ⬇️
server/region_syncer/client.go 85.40% <0.00%> (-1.46%) ⬇️
server/member/leader.go 73.54% <0.00%> (-0.78%) ⬇️
client/base_client.go 90.60% <0.00%> (-0.68%) ⬇️
server/schedule/operator_controller.go 81.25% <0.00%> (-0.17%) ⬇️
client/client.go 71.95% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e7167...6dc2f73. Read the comment docs.

nolouch
nolouch approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 3, 2020
@nolouch
Copy link
Contributor

nolouch commented Sep 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 3, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@nolouch
Copy link
Contributor

nolouch commented Sep 3, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

1 similar comment
@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@glorv
Copy link
Contributor

glorv commented Sep 3, 2020

/run-integration-lightning-test

@nolouch
Copy link
Contributor

nolouch commented Sep 3, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@nolouch
Copy link
Contributor

nolouch commented Sep 4, 2020

/run-all-tests

@nolouch
Copy link
Contributor

nolouch commented Sep 6, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 7, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2907

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 6830f5b into tikv:release-4.0 Sep 7, 2020
This was referenced Sep 10, 2020
Merged
Merged
@JmPotato JmPotato deleted the release-4.0-15c47e78dd05 branch September 26, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

Assignees

@ti-srebot ti-srebot

Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @nolouch @glorv @lhy1024 @lizhemingi