Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove useless rebase #3150

Merged
merged 7 commits into from
Nov 5, 2020
Merged

Conversation

Rustin170506
Copy link
Member

Signed-off-by: hi-rustin rustin.liu@gmail.com

What problem does this PR solve?

#3134 (comment)

What is changed and how it works?

Use author name.

Check List

Tests

  • No code

Code changes

None

Side effects

None
Related changes

None

Release note

  • No release note

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member Author

/cc @HunDunDM @Yisaer

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 4, 2020
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2020
@Rustin170506
Copy link
Member Author

Rustin170506 commented Nov 4, 2020

/run-all-tests

1 similar comment
@JmPotato
Copy link
Member

JmPotato commented Nov 4, 2020

/run-all-tests

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@HunDunDM
Copy link
Member

HunDunDM commented Nov 4, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 2f712de820dba85360fab7e1b66bdd149dc63153

@Rustin170506
Copy link
Member Author

/rebase

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2020
@Rustin170506
Copy link
Member Author

/lgtm cancel

@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Nov 4, 2020
@Rustin170506 Rustin170506 marked this pull request as draft November 4, 2020 12:57
@Rustin170506
Copy link
Member Author

Still have some problems.

@Rustin170506
Copy link
Member Author

Rustin170506 commented Nov 4, 2020

Sorry I am an idiot, rebase always change the hash.
I will find another way to fix it.

@Rustin170506 Rustin170506 reopened this Nov 4, 2020
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 marked this pull request as ready for review November 4, 2020 14:41
@Rustin170506 Rustin170506 changed the title ci: fix rebase committer bug ci: remove useless rebase Nov 4, 2020
@Rustin170506
Copy link
Member Author

@HunDunDM @JmPotato @lhy1024

Now you can merge the master into your PR, if you use the Update branch button, the bot will keep the "status/can-merge" label.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 5, 2020

/lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Nov 5, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 22326850f916ec9f303ec72baf0421f9303ab92a

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 52c9fa5

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/run-all-tests

@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 518ae55

@HunDunDM HunDunDM added the component/build Build process. label Nov 5, 2020
@ti-chi-bot ti-chi-bot merged commit 4d4d293 into tikv:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Build process. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants