Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoscaling: fix the label of auto scaling group #3157

Merged
merged 3 commits into from
Nov 5, 2020
Merged

autoscaling: fix the label of auto scaling group #3157

merged 3 commits into from
Nov 5, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 5, 2020

What problem does this PR solve?

Just as the title says.

What is changed and how it works?

This PR adds a dash in the scaling store label.

Check List

Tests

  • Unit test

Release note

@rleungx
fix the label of auto scaling group
c6d308f 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/auto-scaling Auto scaling TiKV/TiDB logic. label Nov 5, 2020
Yisaer
Yisaer approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 5, 2020
@rleungx
Copy link
Member Author

rleungx commented Nov 5, 2020

/merge

@ti-chi-bot
Copy link
Member

@rleungx: you cannot merge your own PR.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@Yisaer
Copy link
Contributor

Yisaer commented Nov 5, 2020

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: adding 'status/can-merge' to this PR must have 2 LGTMs

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: adding 'status/can-merge' to this PR must have 2 LGTMs

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 430e438

@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 1113719 into tikv:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HunDunDM HunDunDM HunDunDM approved these changes

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
component/auto-scaling Auto scaling TiKV/TiDB logic. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @ti-chi-bot @Yisaer @HunDunDM