Persist temporary setting to etcd (#3131) #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
@longfangsong please accept the invitation then you can push to the cherry-pick pull requests. |
longfangsong
force-pushed
the
release-4.0-1eeb4c87a3fe
branch
from
458c4d8
to
7404ff3
Compare
Signed-off-by: longfangsong <longfangsong@icloud.com>
longfangsong
force-pushed
the
release-4.0-1eeb4c87a3fe
branch
from
7404ff3
to
6fd9a82
Compare
|
/merge |
|
@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. |
ti-chi-bot
added
the
status/can-merge
|
Can merge label has been added. Git tree hash: fb6a96f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #3131 to release-4.0
Signed-off-by: longfangsong longfangsong@icloud.com
What problem does this PR solve?
Sometimes lightning and BR want to patch some of the configuation, #3082 support this, but this implemetion store all the temporary setting in memory, this will cause these settings not taking effect when pd master in cluster is down.
What is changed and how it works?
Save the temporary setting to etcd
See this doc for details.
Check List
Tests
Code changes
Side effects
Release note