Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepsource analyze #3271

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Add deepsource analyze #3271

merged 2 commits into from
Dec 15, 2020

Conversation

zhouqiang-cl
Copy link
Contributor

Signed-off-by: Qiang Zhou zhouqiang.cl@gmail.com

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

  • No release note

Signed-off-by: Qiang Zhou <zhouqiang.cl@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2020
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 15, 2020
@rleungx
Copy link
Member

rleungx commented Dec 15, 2020

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: b15c3a3

@rleungx
Copy link
Member

rleungx commented Dec 15, 2020

/run-unit-tests

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: Your PR has out-of-dated and I have automatically updated it for you.
At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@rleungx
Copy link
Member

rleungx commented Dec 15, 2020

/run-integration-ddl-test

1 similar comment
@zhouqiang-cl
Copy link
Contributor Author

/run-integration-ddl-test

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #3271 (8bda4c0) into master (0ea4713) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3271   +/-   ##
=======================================
  Coverage   73.97%   73.97%           
=======================================
  Files         242      242           
  Lines       23029    23029           
=======================================
+ Hits        17035    17036    +1     
  Misses       4414     4414           
+ Partials     1580     1579    -1     
Flag Coverage Δ
unittests 73.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/etcdutil/etcdutil.go 80.88% <0.00%> (-4.42%) ⬇️
server/schedule/region_scatterer.go 80.61% <0.00%> (-3.58%) ⬇️
server/election/leadership.go 78.75% <0.00%> (-2.50%) ⬇️
server/grpc_service.go 54.62% <0.00%> (-0.52%) ⬇️
client/client.go 64.36% <0.00%> (-0.38%) ⬇️
server/server.go 73.29% <0.00%> (-0.32%) ⬇️
server/cluster/cluster.go 80.65% <0.00%> (+0.12%) ⬆️
server/tso/allocator_manager.go 76.00% <0.00%> (+0.60%) ⬆️
server/schedule/operator_controller.go 80.68% <0.00%> (+0.76%) ⬆️
server/core/storage.go 68.80% <0.00%> (+0.79%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea4713...8bda4c0. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 5d57556 into tikv:master Dec 15, 2020
@HunDunDM
Copy link
Member

Please update the description.

@nolouch nolouch added needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. labels Dec 23, 2020
@nolouch
Copy link
Contributor

nolouch commented Dec 23, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Dec 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3294

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Dec 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3295

nolouch pushed a commit that referenced this pull request Dec 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: zhouqiang <zhouqiang.cl@gmail.com>
nolouch pushed a commit that referenced this pull request Dec 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: zhouqiang <zhouqiang.cl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants