Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix the bug that the isolation level is wrong when the store lacks label (#3467) #3474

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 12, 2021

cherry-pick #3467 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In pd repo:
git pr https://github.com/tikv/pd/pull/3474

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/pd.git pr/3474:release-4.0-3c81817831e9

What problem does this PR solve?

close #3455

What is changed and how it works?

  • statistics: fix the bug that the isolation level is wrong when the store lacks label

example

  • pd location-labels: region,host
  • tikv1 label: {host: 1}
  • tikv2 label: {host: 2}
  • tikv3 label: {host: 3}
  • Before
    • image
  • After
    • image

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fix the bug that the isolation level is wrong when the store lacks label

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot
Copy link
Contributor Author

@HunDunDM you're already a collaborator in bot's repo.

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM
Copy link
Member

/rebuild

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a0a2097

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #3474 (a0a2097) into release-4.0 (3f81ab7) will increase coverage by 0.17%.
The diff coverage is 94.44%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3474      +/-   ##
===============================================
+ Coverage        74.69%   74.87%   +0.17%     
===============================================
  Files              209      209              
  Lines            19809    19811       +2     
===============================================
+ Hits             14797    14833      +36     
+ Misses            3674     3649      -25     
+ Partials          1338     1329       -9     
Flag Coverage Δ
unittests 74.87% <94.44%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/region_collection.go 93.85% <94.11%> (+4.57%) ⬆️
server/cluster/cluster.go 78.57% <100.00%> (ø)
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
client/client.go 69.54% <0.00%> (+0.50%) ⬆️
server/member/leader.go 70.64% <0.00%> (+6.88%) ⬆️
pkg/etcdutil/etcdutil.go 85.29% <0.00%> (+7.35%) ⬆️
server/kv/etcd_kv.go 79.71% <0.00%> (+10.14%) ⬆️
pkg/errs/errs.go 100.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f81ab7...a0a2097. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 5b5bc83 into tikv:release-4.0 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. component/statistics Statistics for scheduling. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants