-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: fix the bug that the isolation level is wrong when the store lacks label (#3467) #3474
statistics: fix the bug that the isolation level is wrong when the store lacks label (#3467) #3474
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
@HunDunDM you're already a collaborator in bot's repo. |
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a0a2097
|
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3474 +/- ##
===============================================
+ Coverage 74.69% 74.87% +0.17%
===============================================
Files 209 209
Lines 19809 19811 +2
===============================================
+ Hits 14797 14833 +36
+ Misses 3674 3649 -25
+ Partials 1338 1329 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cherry-pick #3467 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In pd repo: git pr https://github.com/tikv/pd/pull/3474
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
close #3455
What is changed and how it works?
example
Check List
Tests
Related changes
Release note