-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: fix race for region scatter (#3760) #3762
schedule: fix race for region scatter (#3760) #3762
Conversation
Codecov Report
@@ Coverage Diff @@
## release-5.0 #3762 +/- ##
===============================================
+ Coverage 74.61% 74.66% +0.05%
===============================================
Files 245 245
Lines 24183 24185 +2
===============================================
+ Hits 18043 18057 +14
+ Misses 4521 4514 -7
+ Partials 1619 1614 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3521301
|
This is an automated cherry-pick of #3760
Signed-off-by: yisaer disxiaofei@163.com
What problem does this PR solve?
As
totalCountByStore
calling the functiongetDistributionByGroupLocked
, this function should be procteded by rw mutex otherwise it will cause data race panicWhat is changed and how it works?
Add mutex to protect it.
Check List
Tests
Release note