-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checker: avoid to merge region with high qps #3805
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
Codecov Report
@@ Coverage Diff @@
## master #3805 +/- ##
==========================================
+ Coverage 75.03% 75.04% +0.01%
==========================================
Files 245 245
Lines 24597 24604 +7
==========================================
+ Hits 18456 18464 +8
+ Misses 4518 4517 -1
Partials 1623 1623
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -634,6 +634,8 @@ type ScheduleConfig struct { | |||
MaxMergeRegionKeys uint64 `toml:"max-merge-region-keys" json:"max-merge-region-keys"` | |||
// SplitMergeInterval is the minimum interval time to permit merge after split. | |||
SplitMergeInterval typeutil.Duration `toml:"split-merge-interval" json:"split-merge-interval"` | |||
// SplitQPSThreshold is the qps threshold for split region. | |||
SplitQPSThreshold uint64 `toml:"split-qps-threshold" json:"split-qps-threshold"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we know this from TiKV? I think we can use ConfigManager
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to use ConfigManager
?And I think we can also get StoreHeartbeatInterval
and RegionHeartbeatInterval
from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if this threshold is not the same between PD and TiKV?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the pd threshold is higher than the tikv threshold, some regions may not be merged as expected, and conversely, some regions that were just split by qps may be merged again, so we expect them to be the same, or not much different
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
I think we need some document update. |
Considering that qps will be used as the dimension for reading hotspot scheduling and that the merge checker will skip regions already identified as hotspots, this pr is unnecessary and I will close it. |
Signed-off-by: lhy1024 admin@liudos.us
What problem does this PR solve?
avoid to merge region with high qps
Check List
Tests
Release note