Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region_syncer: reduce saveKV of client (#3808) #3932

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3808

What problem does this PR solve?

What is changed and how it works?

  • By introducing part of the heartbeat processing logic in the client of region_syncer, unnecessary saveKV operations are reduced.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

Improved the performance of synchronizing Region information between PDs.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/cluster Cluster logic. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. labels Aug 2, 2021
@HunDunDM HunDunDM added this to the v4.0.15 milestone Aug 11, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 3, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM force-pushed the cherry-pick-3808-to-release-4.0 branch from 4cfa480 to 025141e Compare September 8, 2021 10:04
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #3932 (025141e) into release-4.0 (2ddff54) will decrease coverage by 0.16%.
The diff coverage is 92.68%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3932      +/-   ##
===============================================
- Coverage        75.13%   74.96%   -0.17%     
===============================================
  Files              211      211              
  Lines            20026    20046      +20     
===============================================
- Hits             15046    15028      -18     
- Misses            3638     3691      +53     
+ Partials          1342     1327      -15     
Flag Coverage Δ
unittests 74.96% <92.68%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/region_syncer/client.go 77.94% <78.57%> (-5.53%) ⬇️
server/region_syncer/server.go 79.25% <83.33%> (-10.06%) ⬇️
server/core/region.go 92.38% <96.72%> (+0.64%) ⬆️
server/cluster/cluster.go 77.65% <100.00%> (-3.56%) ⬇️
server/statistics/store_collection.go 58.53% <0.00%> (-34.96%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/member/lease.go 91.07% <0.00%> (-1.79%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddff54...025141e. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 8, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 025141e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2021
@ti-chi-bot ti-chi-bot merged commit 99e700e into tikv:release-4.0 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cluster Cluster logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants