-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: set different priorities for write-leader and write-peer #3937
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3937 +/- ##
==========================================
- Coverage 74.72% 74.63% -0.09%
==========================================
Files 246 246
Lines 25068 25068
==========================================
- Hits 18731 18709 -22
- Misses 4685 4702 +17
- Partials 1652 1657 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
It's may conflict? especially we add qps. |
Signed-off-by: lhy1024 <admin@liudos.us>
In fact, the write leader's priority now has key as first priority and byte as second priority, while the write peer's priority has byte as first priority and key as second priority. They are now different. This pr doesn't change the default behaviour, it just avoids query in the write peer's scheduling priority. because the follower doesn't have this statistic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: lhy1024 <admin@liudos.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: lhy1024 <admin@liudos.us>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 68b184f
|
What problem does this PR solve?
write-leader and write-peer need to have different priorities because write leader needs to have balanced metrics that reflect the leader, such as sum of key or qps, but write-peer does not, and write-peer does not necessarily have data on qps.
What is changed and how it works?
set different priorities for write-leader and write-peer
Check List
Tests
Release note