Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: consider evict leader when calc expect (#3967) #3975

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3967

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

fix #3959

What is changed and how it works?

  1. consider evict leader when calc expect
  2. reduce the pending amp factor
  3. unify qps and query as query, to ensure consistency with the documentation pd-control: add new config of balance-hot-region-scheduler pingcap/docs-cn#6835

Check List

Tests

  • Unit test

Related changes

Release note

None.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lhy1024
Copy link
Contributor

lhy1024 commented Aug 12, 2021

it will wait until cherry-pick of #3870 merged

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 13, 2021
@HunDunDM HunDunDM modified the milestone: v5.0.4 Aug 13, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 16, 2021

cc @HunDunDM

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 force-pushed the cherry-pick-3967-to-release-5.0 branch from 729f38b to ccd434d Compare August 16, 2021 10:32
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3975 (5953a73) into release-5.0 (6864bb3) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #3975      +/-   ##
===============================================
+ Coverage        74.71%   74.74%   +0.03%     
===============================================
  Files              245      245              
  Lines            24248    24256       +8     
===============================================
+ Hits             18116    18131      +15     
+ Misses            4517     4511       -6     
+ Partials          1615     1614       -1     
Flag Coverage Δ
unittests 74.74% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mock/mockcluster/mockcluster.go 93.93% <66.66%> (-0.49%) ⬇️
server/schedulers/hot_region.go 80.85% <100.00%> (+0.06%) ⬆️
server/tso/tso.go 69.93% <0.00%> (-2.46%) ⬇️
client/base_client.go 82.47% <0.00%> (-2.07%) ⬇️
server/server.go 73.19% <0.00%> (-0.61%) ⬇️
server/member/member.go 64.67% <0.00%> (-0.55%) ⬇️
client/client.go 72.10% <0.00%> (-0.42%) ⬇️
server/cluster/cluster.go 82.95% <0.00%> (-0.37%) ⬇️
server/grpc_service.go 46.83% <0.00%> (-0.12%) ⬇️
server/cluster/coordinator.go 75.89% <0.00%> (+0.71%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6864bb3...5953a73. Read the comment docs.

Signed-off-by: lhy1024 <admin@liudos.us>
@HunDunDM
Copy link
Member

/rebuild

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 27, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 27, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5953a73

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021
@ti-chi-bot ti-chi-bot merged commit 88726b2 into tikv:release-5.0 Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants