Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: replace delta with rate #4015

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Aug 20, 2021

Signed-off-by: bufferflies 1045931706@qq.com

What problem does this PR solve?

scheduler some metrics using delta is not correct.
delta: return the last element - the first element in time zone ,so it could not express the ops
rate: return the average increase rate in the time zone

What is changed and how it works?

replace delta with rate

Check List

Tests

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

replace delta with rate in scheduler panel

Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #4015 (5ac58a6) into master (4a5a745) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4015      +/-   ##
==========================================
+ Coverage   74.49%   74.61%   +0.12%     
==========================================
  Files         256      256              
  Lines       25827    25827              
==========================================
+ Hits        19239    19272      +33     
+ Misses       4866     4844      -22     
+ Partials     1722     1711      -11     
Flag Coverage Δ
unittests 74.61% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/region_syncer/client.go 77.46% <0.00%> (-4.23%) ⬇️
server/statistics/hot_cache_task.go 75.00% <0.00%> (-4.17%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/server.go 72.03% <0.00%> (+0.15%) ⬆️
server/grpc_service.go 47.45% <0.00%> (+0.22%) ⬆️
server/member/member.go 65.24% <0.00%> (+0.53%) ⬆️
server/tso/allocator_manager.go 67.77% <0.00%> (+0.83%) ⬆️
pkg/btree/btree.go 86.74% <0.00%> (+0.96%) ⬆️
server/schedule/operator/step.go 69.76% <0.00%> (+1.66%) ⬆️
server/kv/etcd_kv.go 72.46% <0.00%> (+2.89%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5a745...5ac58a6. Read the comment docs.

@JmPotato
Copy link
Member

Are there any screenshots of Grafana that show the actual effect?

@rleungx
Copy link
Member

rleungx commented Aug 20, 2021

Please change the title to metrics: replace delta with rate

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2021
@bufferflies bufferflies changed the title [metrics]: replace delta with rate metrics: replace delta with rate Aug 20, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1760ad4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants