-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: replace delta with rate #4015
Conversation
Signed-off-by: bufferflies <1045931706@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4015 +/- ##
==========================================
+ Coverage 74.49% 74.61% +0.12%
==========================================
Files 256 256
Lines 25827 25827
==========================================
+ Hits 19239 19272 +33
+ Misses 4866 4844 -22
+ Partials 1722 1711 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Are there any screenshots of Grafana that show the actual effect? |
Please change the title to |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1760ad4
|
Signed-off-by: bufferflies 1045931706@qq.com
What problem does this PR solve?
scheduler some metrics using delta is not correct.
delta: return the last element - the first element in time zone ,so it could not express the ops
rate: return the average increase rate in the time zone
What is changed and how it works?
replace delta with rate
Check List
Tests
Code changes
Side effects
Related changes
Release note