-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: allow cancel load region (#4175) #4218
core: allow cancel load region (#4175) #4218
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
This reverts commit 5b69c4a. Signed-off-by: disksing <i@disksing.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: disksing <i@disksing.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
the statics check failed in test. |
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: b1ff18b
|
/run-all-tests |
[FORMAT CHECKER NOTIFICATION] Please provide the associated issue number in the commit messages, for example: |
/run-all-tests |
2 similar comments
/run-all-tests |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #4218 +/- ##
===============================================
+ Coverage 74.78% 74.98% +0.20%
===============================================
Files 245 245
Lines 24370 24362 -8
===============================================
+ Hits 18225 18268 +43
+ Misses 4520 4489 -31
+ Partials 1625 1605 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is an automated cherry-pick of #4175
What problem does this PR solve?
Fix #3936
What is changed and how it works?
chan bool
withcontextes
in region syncer clientCheck List
Tests
Release note