Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TiDB Dashboard to v2021.11.01.1 [master] #4253

Conversation

tidb-dashboard-bot
Copy link
Contributor

What problem does this PR solve?

Update TiDB Dashboard to v2021.11.01.1.

Upstream commit: pingcap/tidb-dashboard@08e58c0 .

Release note

None

Signed-off-by: tidb-dashboard-bot <tidb-dashboard-bot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-commit-message release-note-none Denotes a PR that doesn't merit a release note. labels Oct 31, 2021
@github-actions github-actions bot added component/visualization Visualization. require-LGT1 Indicates that the PR requires an LGTM. labels Oct 31, 2021
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #4253 (cc43026) into master (701b94f) will increase coverage by 74.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4253       +/-   ##
===========================================
+ Coverage        0   74.77%   +74.77%     
===========================================
  Files           0      264      +264     
  Lines           0    27253    +27253     
===========================================
+ Hits            0    20379    +20379     
- Misses          0     5048     +5048     
- Partials        0     1826     +1826     
Flag Coverage Δ
unittests 74.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/encryption/kms.go 0.00% <0.00%> (ø)
pkg/movingaverage/hull_moving_average.go 100.00% <0.00%> (ø)
server/schedule/labeler/labeler.go 79.59% <0.00%> (ø)
tools/pd-simulator/simulator/simutil/key.go 44.00% <0.00%> (ø)
server/tso/local_allocator.go 64.86% <0.00%> (ø)
server/api/admin.go 50.87% <0.00%> (ø)
server/schedule/checker/replica_strategy.go 92.50% <0.00%> (ø)
tests/cluster.go 80.78% <0.00%> (ø)
server/api/component.go 63.15% <0.00%> (ø)
server/schedule/rangelist/builder.go 100.00% <0.00%> (ø)
... and 254 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701b94f...cc43026. Read the comment docs.

Signed-off-by: Breezewish <me@breeswish.org>
@breezewish
Copy link
Member

As a ref, this PR includes the following changes:

  1. Continuous Profiling support in TiDB Dashboard
  2. Fix panic in some scenarios (as in dashboard: update to v2021.10.29.1 to fix tidb-dashboard panic #4246)

@ti-chi-bot
Copy link
Member

@crazycs520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HunDunDM HunDunDM linked an issue Nov 1, 2021 that may be closed by this pull request
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Nov 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cc43026

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@breeswish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@breeswish: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f1cbf60 into tikv:master Nov 1, 2021
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
* Update TiDB Dashboard to v2021.11.01.1

Signed-off-by: tidb-dashboard-bot <tidb-dashboard-bot@pingcap.com>

* ref tikv#4257

Signed-off-by: Breezewish <me@breeswish.org>

Co-authored-by: tidb-dashboard-bot <tidb-dashboard-bot@pingcap.com>
Co-authored-by: Breezewish <me@breeswish.org>
Co-authored-by: 混沌DM <hundundm@gmail.com>
Signed-off-by: hzh0425 <642256541@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/visualization Visualization. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic caused by tidb-dashboard profiling
5 participants