-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update sysutil in go.mod to fix panic when search log #4438
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please address the commit message.
Codecov Report
@@ Coverage Diff @@
## master #4438 +/- ##
==========================================
- Coverage 74.87% 74.81% -0.07%
==========================================
Files 263 263
Lines 27678 27678
==========================================
- Hits 20725 20707 -18
- Misses 5103 5121 +18
Partials 1850 1850
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4b1e60e
to
d78dc95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lonng: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@lonng: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@lonng: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Please change the commit message according to https://github.com/tikv/pd/blob/master/CONTRIBUTING.md#format-of-the-commit-message |
…4440 in tidb Signed-off-by: crazycs <chen.two.cs@gmail.com>
d78dc95
to
211fc7f
Compare
/merge |
@crazycs520: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@crazycs520: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e7cc7b3
|
/run-unit-test |
Signed-off-by: crazycs chen.two.cs@gmail.com
What problem does this PR solve?
close #4440
update
sysutil
ingo.mod
to fix panic when search log.related PR: pingcap/sysutil#33
Check List
Tests
Code changes
Side effects
Related changes
Release note