Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update sysutil in go.mod to fix panic when search log #4438

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Dec 8, 2021

Signed-off-by: crazycs chen.two.cs@gmail.com

What problem does this PR solve?

close #4440

update sysutil in go.mod to fix panic when search log.

related PR: pingcap/sysutil#33

Check List

Tests

  • Unit test

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • N/A

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-commit-message release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2021
@crazycs520
Copy link
Contributor Author

@nolouch @HunDunDM PTAL

Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address the commit message.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #4438 (e7cc7b3) into master (4ec9e14) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4438      +/-   ##
==========================================
- Coverage   74.87%   74.81%   -0.07%     
==========================================
  Files         263      263              
  Lines       27678    27678              
==========================================
- Hits        20725    20707      -18     
- Misses       5103     5121      +18     
  Partials     1850     1850              
Flag Coverage Δ
unittests 74.81% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-5.16%) ⬇️
server/region_syncer/server.go 81.41% <0.00%> (-5.13%) ⬇️
server/tso/tso.go 61.93% <0.00%> (-3.41%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
pkg/etcdutil/etcdutil.go 82.35% <0.00%> (-2.36%) ⬇️
server/member/member.go 63.10% <0.00%> (-2.14%) ⬇️
server/schedule/operator_controller.go 82.68% <0.00%> (-1.23%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
client/client.go 72.53% <0.00%> (-0.12%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec9e14...e7cc7b3. Read the comment docs.

@crazycs520 crazycs520 changed the title *: update sysutil in go.mod to fix panic when search log *: update sysutil in go.mod to fix panic when search log, close #27795 in tidb Dec 8, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2021
Copy link
Member

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@lonng: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lonng
Copy link
Member

lonng commented Dec 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@lonng: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@lonng: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx
Copy link
Member

rleungx commented Dec 8, 2021

Please change the commit message according to https://github.com/tikv/pd/blob/master/CONTRIBUTING.md#format-of-the-commit-message

@rleungx rleungx changed the title *: update sysutil in go.mod to fix panic when search log, close #27795 in tidb *: update sysutil in go.mod to fix panic when search log Dec 8, 2021
…4440

in tidb

Signed-off-by: crazycs <chen.two.cs@gmail.com>
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@crazycs520: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@crazycs520: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato
Copy link
Member

JmPotato commented Dec 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e7cc7b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2021
@JmPotato
Copy link
Member

JmPotato commented Dec 8, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 055b433 into tikv:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic in search log
5 participants