Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix TestMixedTSODeployment case #6312

Closed
wants to merge 1 commit into from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 12, 2023

What problem does this PR solve?

Issue Number: Close #6304.

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 12, 2023
@rleungx rleungx changed the title try to fix TestMixedTSODeployment *: fix TestMixedTSODeployment case Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (3e6ac89) 75.13% compared to head (c31df3d) 75.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6312      +/-   ##
==========================================
- Coverage   75.13%   75.11%   -0.02%     
==========================================
  Files         404      404              
  Lines       39686    39698      +12     
==========================================
+ Hits        29819    29821       +2     
- Misses       7267     7275       +8     
- Partials     2600     2602       +2     
Flag Coverage Δ
unittests 75.11% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pd_service_discovery.go 86.72% <100.00%> (-0.48%) ⬇️
pkg/mcs/resource_manager/server/server.go 52.58% <100.00%> (-0.21%) ⬇️
pkg/mcs/tso/server/server.go 46.72% <100.00%> (-0.67%) ⬇️

... and 38 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2023
@ti-chi-bot
Copy link
Member

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rleungx
Copy link
Member Author

rleungx commented Jun 21, 2023

Close it since the original issue has been fixed.

@rleungx rleungx closed this Jun 21, 2023
@rleungx rleungx deleted the fix-unstable-test branch June 21, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestMixedTSODeployment timeout sometimes
2 participants