Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix unhealth region skip the rule check (#6427) #6431

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6427

What problem does this PR solve?

Issue Number: Close #6426

What is changed and how does it work?

allow the `schedule=deny` label can do rule constraints check

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 10, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels May 10, 2023
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label May 10, 2023
@ti-chi-bot ti-chi-bot bot requested review from rleungx and Yisaer May 10, 2023 14:41
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 10, 2023
@nolouch nolouch requested review from bufferflies and removed request for Yisaer May 10, 2023 14:47
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (827ded0) 74.94% compared to head (45dc8ac) 75.02%.

❗ Current head 45dc8ac differs from pull request most recent head ce8d9be. Consider uploading reports for the commit ce8d9be to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #6431      +/-   ##
===============================================
+ Coverage        74.94%   75.02%   +0.07%     
===============================================
  Files              408      408              
  Lines            40628    40633       +5     
===============================================
+ Hits             30450    30486      +36     
+ Misses            7512     7493      -19     
+ Partials          2666     2654      -12     
Flag Coverage Δ
unittests 75.02% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/schedule/operator_controller.go 86.51% <ø> (-1.74%) ⬇️
server/cluster/cluster.go 81.52% <ø> (-0.16%) ⬇️
pkg/schedule/checker/checker_controller.go 80.00% <100.00%> (+2.47%) ⬆️
pkg/schedule/metrics.go 100.00% <100.00%> (ø)
server/cluster/coordinator.go 72.81% <100.00%> (-0.35%) ⬇️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2023
@nolouch
Copy link
Contributor

nolouch commented May 11, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 45dc8ac

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit e77b5ad into tikv:release-7.1 May 11, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants