-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: fix duplicate ID #7636
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7636 +/- ##
==========================================
- Coverage 74.73% 74.67% -0.06%
==========================================
Files 459 459
Lines 50975 50975
==========================================
- Hits 38094 38068 -26
- Misses 9511 9519 +8
- Partials 3370 3388 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
check #7588 again, no other errors. |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: fb7014e
|
ref tikv#4399 Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Signed-off-by: pingandb <songge102@pingan.com.cn>
What problem does this PR solve?
Issue Number: ref #4399
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note