Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix duplicate ID #7636

Merged
merged 1 commit into from
Dec 28, 2023
Merged

metrics: fix duplicate ID #7636

merged 1 commit into from
Dec 28, 2023

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4399

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    image

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 28, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2023
@CabinfeverB CabinfeverB requested review from HuSharp and removed request for JmPotato December 28, 2023 08:41
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #7636 (fb7014e) into master (b7b4537) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7636      +/-   ##
==========================================
- Coverage   74.73%   74.67%   -0.06%     
==========================================
  Files         459      459              
  Lines       50975    50975              
==========================================
- Hits        38094    38068      -26     
- Misses       9511     9519       +8     
- Partials     3370     3388      +18     
Flag Coverage Δ
unittests 74.67% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@CabinfeverB
Copy link
Member Author

check #7588 again, no other errors.
And check all panels in manual test.

@CabinfeverB
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: fb7014e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit c7644be into tikv:master Dec 28, 2023
27 checks passed
pingandb pushed a commit to pingandb/pd that referenced this pull request Jan 18, 2024
ref tikv#4399

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants