-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix update-dashboard script not work when target is semver style #7638
fix: fix update-dashboard script not work when target is semver style #7638
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @baurine. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b178426
to
d925253
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7638 +/- ##
==========================================
- Coverage 74.78% 74.72% -0.07%
==========================================
Files 459 459
Lines 50975 50975
==========================================
- Hits 38123 38089 -34
- Misses 9478 9504 +26
- Partials 3374 3382 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
d925253
to
f9a2e4a
Compare
f9a2e4a
to
19224fb
Compare
Signed-off-by: baurine <2008.hbl@gmail.com>
19224fb
to
980853a
Compare
/ok-to-test |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 980853a
|
/cherry-pick release-7.5 |
/cherry-pick release-7.1 |
/cherry-pick release-6.5 |
@baurine: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#7637 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@baurine: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#7637 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@baurine: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#7637 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
…tikv#7638) close tikv#7637 none Signed-off-by: baurine <2008.hbl@gmail.com> Signed-off-by: pingandb <songge102@pingan.com.cn>
…tikv#7638) close tikv#7637 none Signed-off-by: baurine <2008.hbl@gmail.com>
…tikv#7638) close tikv#7637 none Signed-off-by: baurine <2008.hbl@gmail.com>
…tikv#7638) close tikv#7637 none Signed-off-by: baurine <2008.hbl@gmail.com>
What problem does this PR solve?
Issue Number: Close #7637
What is changed and how does it work?
This PR fix the
scripts/update-dashboard
script can't work with dashboard semver style version format.Test
Release note