-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: update evict-leader-scheduler&grant-leader-scheduler to return the same success message #7802
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
// we should ensure whether it is the first time to create evict-leader-scheduler | ||
// or just update the evict-leader. | ||
if exist { | ||
h.r.JSON(w, http.StatusOK, "The scheduler has been applied to the store.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep consistent with
pd/pkg/schedule/schedulers/evict_leader.go
Line 395 in cd0ffba
handler.rd.JSON(w, http.StatusOK, "The scheduler has been applied to the store.") |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7802 +/- ##
==========================================
- Coverage 73.55% 73.51% -0.05%
==========================================
Files 432 432
Lines 47793 47795 +2
==========================================
- Hits 35153 35135 -18
- Misses 9612 9629 +17
- Partials 3028 3031 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4a55a66
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Ref #7672
What is changed and how does it work?
API scheduler need to keep consistent with
pd/pkg/schedule/schedulers/evict_leader.go
Line 395 in cd0ffba
Check List
Tests
Release note