Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: update evict-leader-scheduler&grant-leader-scheduler to return the same success message #7802

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Feb 4, 2024

What problem does this PR solve?

Issue Number: Ref #7672

What is changed and how does it work?

API scheduler need to keep consistent with

handler.rd.JSON(w, http.StatusOK, "The scheduler has been applied to the store.")

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Feb 4, 2024
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx February 4, 2024 10:11
@HuSharp HuSharp requested review from JmPotato and CabinfeverB and removed request for nolouch and rleungx February 4, 2024 10:11
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2024
// we should ensure whether it is the first time to create evict-leader-scheduler
// or just update the evict-leader.
if exist {
h.r.JSON(w, http.StatusOK, "The scheduler has been applied to the store.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to keep consistent with

handler.rd.JSON(w, http.StatusOK, "The scheduler has been applied to the store.")

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Merging #7802 (4a55a66) into master (21ced9a) will decrease coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is 72.22%.

❗ Current head 4a55a66 differs from pull request most recent head 3e343d6. Consider uploading reports for the commit 3e343d6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7802      +/-   ##
==========================================
- Coverage   73.55%   73.51%   -0.05%     
==========================================
  Files         432      432              
  Lines       47793    47795       +2     
==========================================
- Hits        35153    35135      -18     
- Misses       9612     9629      +17     
- Partials     3028     3031       +3     
Flag Coverage Δ
unittests 73.51% <72.22%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp changed the title api: fix return json api: update evict-leader-scheduler&grant-leader-scheduler to return the same success message Feb 5, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 5, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Feb 5, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 4a55a66

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 12d75c7 into tikv:master Feb 5, 2024
22 checks passed
@HuSharp HuSharp deleted the fix_return_exist branch February 5, 2024 07:15
okJiang pushed a commit to okJiang/pd that referenced this pull request Oct 31, 2024
…he same success message (tikv#7802)

ref tikv#7672

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
okJiang pushed a commit to okJiang/pd that referenced this pull request Oct 31, 2024
…he same success message (tikv#7802)

ref tikv#7672

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <819421878@qq.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 4, 2024
…he same success message (tikv#7802)

ref tikv#7672

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <819421878@qq.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 6, 2024
…he same success message (tikv#7802)

ref tikv#7672

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okJiang <819421878@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants