-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support generate the test coverage file and using it in ci #7991
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
678e18e
to
e2580be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7991 +/- ##
==========================================
+ Coverage 77.40% 77.42% +0.01%
==========================================
Files 471 471
Lines 61387 61387
==========================================
+ Hits 47516 47526 +10
+ Misses 10309 10305 -4
+ Partials 3562 3556 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
7320033
to
d4c26cb
Compare
2c16f62
to
f666fdc
Compare
205f78f
to
adfebc1
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
adfebc1
to
3277755
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/hold |
need to merge ti-community-infra/configs#1048 firstly |
/hold |
/unhold |
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 689f323
|
What problem does this PR solve?
Issue Number: Ref #7969
need merge https://github.com/ti-community-infra/configs/pull/1048/files firstly
What is changed and how does it work?
add coverprofile for pd-ut
support_coverprofile* $ go tool cover --func=xxx github.com/tikv/pd/pkg/audit/audit.go:44: Match 100.0% github.com/tikv/pd/pkg/audit/audit.go:59: ProcessBeforeHandler 0.0% github.com/tikv/pd/pkg/audit/audit.go:83: NewPrometheusHistogramBackend 100.0% github.com/tikv/pd/pkg/audit/audit.go:92: ProcessHTTPRequest 87.5% github.com/tikv/pd/pkg/audit/audit.go:113: NewLocalLogBackend 100.0% github.com/tikv/pd/pkg/audit/audit.go:121: ProcessHTTPRequest 100.0% total: (statements) 90.0%
integrate ci unit tests job
advantage:
now
before
Check List
Tests
Release note