Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/member: change leader priority check ticker to reduce test time #8001

Merged
merged 1 commit into from
Mar 29, 2024
Merged

tests/member: change leader priority check ticker to reduce test time #8001

merged 1 commit into from
Mar 29, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Mar 29, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #7969

What is changed and how does it work?

can reduce 10s+1min(leaderPriority Ticker) to 10s+1s(leaderPriority Ticker)

Check List

Tests

  • Unit test

Release note

None.

@HuSharp
fix test
7401293 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp requested review from lhy1024 and rleungx March 29, 2024 07:02
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2024
lhy1024
lhy1024 approved these changes Mar 29, 2024
View reviewed changes
tests/server/member/member_test.go
@@ -151,7 +152,9 @@ func TestLeaderPriority(t *testing.T) {
re := require.New(t)
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
cluster, err := tests.NewTestCluster(ctx, 3)
cluster, err := tests.NewTestCluster(ctx, 3, func(conf *config.Config, serverName string) {
conf.LeaderPriorityCheckInterval = typeutil.NewDuration(time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we add similar config to speed up other tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not see same tests which rely on this config 🤔

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

Merging #8001 (7401293) into master (87db551) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8001      +/-   ##
==========================================
- Coverage   73.62%   73.58%   -0.04%     
==========================================
  Files         436      436              
  Lines       48474    48474              
==========================================
- Hits        35689    35670      -19     
- Misses       9729     9748      +19     
  Partials     3056     3056
Flag Coverage Δ
unittests 73.58% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp requested a review from JmPotato March 29, 2024 07:50
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Mar 29, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 7401293

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit a44b208 into tikv:master Mar 29, 2024
26 of 27 checks passed
@HuSharp HuSharp deleted the reduce_leader_priority branch March 29, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuSharp @lhy1024 @rleungx