-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: add check action when poll the opeators from opNotifierQueue #8010
Conversation
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @TonsnakeLin. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @disksing @Connor1996 |
/test ? |
@TonsnakeLin: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
// But to be cautions, it only takes effect on merge-region currently. | ||
// If the version of epoch is changed, the region has been splitted or merged, and the key range has been changed. | ||
// The changing for conf_version of epoch doesn't modify the region key range, skipt it. | ||
if (op.Kind()&OpMerge != 0) && region.GetRegionEpoch().GetVersion() != op.RegionEpoch().GetVersion() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to compare the epoch like checkStaleOperator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkStaleOperator
only check the ConfVersion of region epoch which maybe not resolve the issue #7992. For example, "operator add split-region 258 --policy="approximate" will change the version of region 258, but not for ConfVersion.
Another reason is I don't know why limits the checkStaleOperator only to DispatchFromHeartBeat
source https://github.com/tikv/pd/blob/master/pkg/schedule/operator/operator_controller.go#L120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, is it enough to only check the version? Or we also need to check both the version and conf version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At begining, I checked both the version and conf-version. But I think the conf-version changed doesn't mean the key-range changed, the merge operator can still be executed sucessfully. At last I check only the version of RegionEpoch.
um... I'm a little not sure whether to consider conf-version.
Could you give me some suggestion ? @disksing @rleungx , Thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I think there will be a problem if we use !=
since the operator's epoch won't change after creating.
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8010 +/- ##
==========================================
- Coverage 73.60% 73.57% -0.03%
==========================================
Files 436 436
Lines 48516 48512 -4
==========================================
- Hits 35709 35694 -15
- Misses 9743 9755 +12
+ Partials 3064 3063 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 00cfdaf
|
close tikv#7992 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against tikv/pd#release-7.5 from head ti-chi-bot:cherry-pick-8010-to-release-7.5: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 98EE:21F144:5006CCD:80D2AFD:6639C15F and timestamp 2024-05-07 05:51:28 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits"} |
close tikv#7992 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
/cherry-pick release-7.5 |
@TonsnakeLin: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #7992
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note