-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/tests: bump cobra to fix PrintErrln #8021
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8021 +/- ##
==========================================
- Coverage 73.61% 73.57% -0.05%
==========================================
Files 436 436
Lines 48525 48525
==========================================
- Hits 35724 35702 -22
- Misses 9744 9763 +19
- Partials 3057 3060 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f1c95a6
|
What problem does this PR solve?
Issue Number: Close #8022
What is changed and how does it work?
There are some usages with
PrintErrln
inpd-ctl
, for cobra release-1.0.0 which is not redirect to stderr exactlyfixed by this spf13/cobra#894
such as:
pd/tools/pd-ctl/pdctl/command/keyspace_command.go
Lines 107 to 110 in 4356aeb
After updating this library, achieved the right redirect to stderr
Check List
Tests
Release note