Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/tests: bump cobra to fix PrintErrln #8021

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Apr 3, 2024

What problem does this PR solve?

Issue Number: Close #8022

What is changed and how does it work?

There are some usages with PrintErrln in pd-ctl, for cobra release-1.0.0 which is not redirect to stderr exactly
fixed by this spf13/cobra#894
such as:

if err != nil {
cmd.PrintErrln("Failed to get the keyspace information: ", err)
return
}

After updating this library, achieved the right redirect to stderr

image

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #8021 (f1c95a6) into master (a2b0e3c) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8021      +/-   ##
==========================================
- Coverage   73.61%   73.57%   -0.05%     
==========================================
  Files         436      436              
  Lines       48525    48525              
==========================================
- Hits        35724    35702      -22     
- Misses       9744     9763      +19     
- Partials     3057     3060       +3     
Flag Coverage Δ
unittests 73.57% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2024
@HuSharp HuSharp requested a review from nolouch April 3, 2024 07:43
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 3, 2024
@nolouch
Copy link
Contributor

nolouch commented Apr 3, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

This pull request has been accepted and is ready to merge.

Commit hash: f1c95a6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit fff288d into tikv:master Apr 3, 2024
25 of 27 checks passed
@HuSharp HuSharp deleted the update_cobra branch April 3, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools/tests: bump cobra to fix PrintErrln
3 participants