-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: make TestRateLimitConfigReload
stable
#8092
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8092 +/- ##
==========================================
- Coverage 77.31% 77.30% -0.02%
==========================================
Files 470 470
Lines 61115 61129 +14
==========================================
+ Hits 47252 47255 +3
- Misses 10298 10308 +10
- Partials 3565 3566 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
2e7f503
to
ffc29f2
Compare
/hold cancel |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 9b8b334
|
Signed-off-by: Ryan Leung <rleungx@gmail.com>
9b8b334
to
123688c
Compare
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 123688c
|
What problem does this PR solve?
Issue Number: Close #8083.
What is changed and how does it work?
MustWaitLeader
may return nil before because it only tries to iterate servers once.Check List
Tests
Release note