Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/tso: decouple tsoClient and tsoDispatcher #8134

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Apr 28, 2024

What problem does this PR solve?

Issue Number: ref #8047.

What is changed and how does it work?

- Decouple `tsoClient` and `tsoDispatcher` to appropriately categorize different methods.
- Update `connectionCtxsUpdater` to support the Local TSO.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Apr 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2024
@JmPotato JmPotato force-pushed the refine_connectionCtxsUpdater branch 2 times, most recently from f2aa258 to f5b5f1d Compare April 28, 2024 09:59
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 89.36877% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 77.37%. Comparing base (6e3cac7) to head (0dbd932).
Report is 1 commits behind head on master.

❗ Current head 0dbd932 differs from pull request most recent head 7d3dae8. Consider uploading reports for the commit 7d3dae8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8134      +/-   ##
==========================================
+ Coverage   77.33%   77.37%   +0.03%     
==========================================
  Files         471      471              
  Lines       61295    61317      +22     
==========================================
+ Hits        47405    47445      +40     
+ Misses      10319    10301      -18     
  Partials     3571     3571              
Flag Coverage Δ
unittests 77.37% <89.36%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the refine_connectionCtxsUpdater branch from 96b2479 to e9df606 Compare April 30, 2024 04:47
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the refine_connectionCtxsUpdater branch from e9df606 to a613f66 Compare April 30, 2024 04:55
@JmPotato JmPotato requested a review from rleungx April 30, 2024 04:55
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 30, 2024
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 7d3dae8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1679dbc into tikv:master Apr 30, 2024
22 checks passed
@JmPotato JmPotato deleted the refine_connectionCtxsUpdater branch April 30, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants