Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove the overlaps logic in UpdateSubTree #8137

Closed
wants to merge 1 commit into from

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 29, 2024

What problem does this PR solve?

Issue Number: Close #8136

What is changed and how does it work?

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 29, 2024
@ti-chi-bot ti-chi-bot bot requested review from HuSharp and lhy1024 April 29, 2024 06:13
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2024
@nolouch nolouch requested review from rleungx and removed request for lhy1024 and HuSharp April 29, 2024 06:14
@nolouch
Copy link
Contributor Author

nolouch commented Apr 29, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@nolouch nolouch closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getOverlapRegionFromSubTreeLocked consume many cpu hold lock
1 participant