Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/controller: record context error and add slowlog about token bucket (#8344) #8356

Merged
merged 2 commits into from
Jul 4, 2024
Merged

client/controller: record context error and add slowlog about token bucket (#8344) #8356

merged 2 commits into from
Jul 4, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 2, 2024 •
edited by nolouch
Loading

This is an automated cherry-pick of #8344

What problem does this PR solve?

Issue Number: Close #8343 ref #8349

What is changed and how does it work?

client/controller: record context error and add slowlog about token bucket
- record low process start time, and log it if it's too slow
- record the context error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8344
e2508b6 
close tikv#8343

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added affects-7.1 affects-7.5 affects-8.1 approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 2, 2024
Merged
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. label Jul 2, 2024
@ti-chi-bot ti-chi-bot bot removed the approved label Jul 2, 2024
fix
541ccf8 
Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Jul 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1c83af9 into tikv:release-8.1 Jul 4, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@HuSharp HuSharp HuSharp approved these changes

Assignees

@nolouch nolouch

Labels
affects-7.1 affects-7.5 affects-8.1 approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @nolouch @HuSharp