controller: fix the low_ru request missed #8368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
added
needs-cherry-pick-release-7.1
ti-chi-bot
bot
added
the
size/L
Signed-off-by: nolouch <nolouch@gmail.com>
HuSharp
approved these changes
Jul 5, 2024
|
ci failed 2024-07-05T08:05:20.6795433Z limiter_test.go:164:
2024-07-05T08:05:20.6796168Z Error Trace: /home/runner/work/pd/pd/client/resource_group/controller/limiter_test.go:164
2024-07-05T08:05:20.6796820Z Error: Not equal:
2024-07-05T08:05:20.6797226Z expected: 4s
2024-07-05T08:05:20.6797633Z actual : 0s
2024-07-05T08:05:20.6797983Z Test: TestCancel |
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: nolouch <nolouch@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8368 +/- ##
==========================================
- Coverage 77.15% 77.14% -0.02%
==========================================
Files 470 470
Lines 61681 61686 +5
==========================================
- Hits 47589 47586 -3
- Misses 10503 10513 +10
+ Partials 3589 3587 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
JmPotato
approved these changes
Jul 8, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, JmPotato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 8, 2024
close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 8, 2024
close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 8, 2024
close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
close #8349 controller: fix the low_ru request missed The problem is that `c.run.currentRequests` is shared by all groups. If one group triggers a token request that isn't handled by the response, the other group's requests will be discarded. Here, we do not discard the low_ru triggers. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
close #8349 controller: fix the low_ru request missed The problem is that `c.run.currentRequests` is shared by all groups. If one group triggers a token request that isn't handled by the response, the other group's requests will be discarded. Here, we do not discard the low_ru triggers. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
close #8349 controller: fix the low_ru request missed The problem is that `c.run.currentRequests` is shared by all groups. If one group triggers a token request that isn't handled by the response, the other group's requests will be discarded. Here, we do not discard the low_ru triggers. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8349
What is changed and how does it work?
Check List
Tests
Release note