Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: replace pauseLeader with two flags and add source filter to transferIn #8623

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

scheduler: replace pauseLeader with two flags and add source filter to transferIn #8623

wants to merge 2 commits into from
+194 −92

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 13, 2024

…n transferIn

What problem does this PR solve?

Issue Number: Close #8621

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@lhy1024
scheduler: replace pauseLeader with two flags and add source filter t…
c0b3e8a 
…o transferIn

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Sep 13, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lhy1024, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 13, 2024
@lhy1024
fix
921ed79 
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.04651% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.60%. Comparing base (e9714b6) to head (921ed79).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8623   +/-   ##
=======================================
  Coverage   77.60%   77.60%           
=======================================
  Files         474      474           
  Lines       61893    61941   +48     
=======================================
+ Hits        48029    48072   +43     
- Misses      10320    10324    +4     
- Partials     3544     3545    +1
Flag Coverage Δ
unittests 77.60% <86.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Sep 19, 2024
View reviewed changes
pkg/core/basic_cluster.go
@@ -137,8 +137,10 @@ type StoreSetInformer interface {

// StoreSetController is used to control stores' status.
type StoreSetController interface {
PauseLeaderTransfer(id uint64) error
ResumeLeaderTransfer(id uint64)
PauseLeaderTransferIn(id uint64) error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a parameter?

pkg/schedule/schedulers/utils.go
// pauseAndResumeLeaderTransfer checks the old and new store IDs, and pause or resume the leader transfer.
func pauseAndResumeLeaderTransfer[T any](cluster *core.BasicCluster, old, new map[uint64]T) {
// pauseAndResumeLeaderTransferIn checks the old and new store IDs, and pause or resume the leader transfer in.
func pauseAndResumeLeaderTransferIn[T any](cluster *core.BasicCluster, old, new map[uint64]T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scheduler: there is no source filter in transferIn
2 participants
@lhy1024 @rleungx