Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd/path: change leaderPath/dcLocationPath/memberPath/allocalIDPath to absolute path #8789

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

etcd/path: change leaderPath/dcLocationPath/memberPath/allocalIDPath to absolute path #8789

wants to merge 8 commits into from
+196 −117

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Nov 7, 2024

What problem does this PR solve?

Issue Number: Ref #8582

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@okJiang
update leader path
b49d114 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update dcLocationPath
b88e95d 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update member path
2725391 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update allocid path
1b36f77 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cabinfeverb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@okJiang okJiang changed the title etcd: change leaderPath/dcLocationPath/memberPath/allocalIDPath to absolute path etcd/path: change leaderPath/dcLocationPath/memberPath/allocalIDPath to absolute path Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2024
@okJiang
update comment
816dc15 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix lint
78d5b33 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang okJiang marked this pull request as draft November 7, 2024 09:49
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@okJiang
add keyspace group path
cf5c88a 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2024
@okJiang
add comment
a58fab3 
Signed-off-by: okJiang <819421878@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@okJiang