-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the CI to execute on 1.64.0 #225
Conversation
5a632fa
to
3856eda
Compare
As I replied in #221, addr2line 0.21 does not force us to bump MSRV to 1.65 because it's possible to keep the patch version of |
3856eda
to
6f7fba6
Compare
.github/workflows/rust.yml
Outdated
@@ -35,6 +35,13 @@ jobs: | |||
- name: Remove pre-generated prost files to force regeneration | |||
run: rm proto/*.rs | |||
|
|||
- name: Set precise version to allow building on 1.64.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about commit Cargo.lock
into the repo so that developers don't need to figure all of those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion. I've read https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html and rust-lang/cargo@3bb02f2. It seems good to just commit the .lock
file 🍻.
a7aa746
to
6c02fcb
Compare
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
6c02fcb
to
f23bebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After patching the minor version of
pprof-rs
, it can actually run on 1.64.0