Modify the CI to execute on 1.64.0 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2023
Xuanwo
approved these changes
Sep 26, 2023
Xuanwo
approved these changes
Sep 26, 2023
YangKeao
force-pushed
the
bump-msrv-to-1.65.0
branch
5 times, most recently
from
5a632fa
to
3856eda
Compare
|
As I replied in #221, addr2line 0.21 does not force us to bump MSRV to 1.65 because it's possible to keep the patch version of |
YangKeao
force-pushed
the
bump-msrv-to-1.65.0
branch
from
3856eda
to
6f7fba6
Compare
Xuanwo
reviewed
Sep 26, 2023
.github/workflows/rust.yml
Outdated
| @@ -35,6 +35,13 @@ jobs: | |||
| - name: Remove pre-generated prost files to force regeneration | |||
| run: rm proto/*.rs | |||
|
|
|||
| - name: Set precise version to allow building on 1.64.0 | |||
There was a problem hiding this comment.
How about commit Cargo.lock into the repo so that developers don't need to figure all of those?
There was a problem hiding this comment.
Nice suggestion. I've read https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html and rust-lang/cargo@3bb02f2. It seems good to just commit the .lock file 🍻.
YangKeao
force-pushed
the
bump-msrv-to-1.65.0
branch
2 times, most recently
from
a7aa746
to
6c02fcb
Compare
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
YangKeao
force-pushed
the
bump-msrv-to-1.65.0
branch
from
6c02fcb
to
f23bebd
Compare
Xuanwo
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After patching the minor version of
pprof-rs, it can actually run on 1.64.0