-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc: Fix GcKeys task doesn't work when called with multiple keys (#11248) #11283
gc: Fix GcKeys task doesn't work when called with multiple keys (#11248) #11283
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@Connor1996 you're already a collaborator in bot's repo. |
@yiwu-arbug The conflicts are not resolved yet in this PR, and the other PR for 5.1 branch. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Signed-off-by: Connor1996 <zbk602423539@gmail.com>
* close tikv#11290 fix compaction guard panic on non-data key Signed-off-by: Connor1996 <zbk602423539@gmail.com> * add comment Signed-off-by: Connor1996 <zbk602423539@gmail.com>
34c5606
to
dd8f527
Compare
/merge |
@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6061b5d
|
/test |
cherry-pick #11248 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/11283
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #11217
Problem Summary:
The problem is because
gc_worker
passes the range with z-prefixed keys to get regions in the range, whereasRegionInfoProvider
actually accepts keys without z-prefixed. So it causesget_regions_in_range
returns incorrect results leading to unexpected behavior of handlingGcKeys
task.Apart from that, find two more bugs:
gc_keys
wrongly assume the start key and end key of region are z-prefixedhandle_get_regions_in_range
doesn't returned all covered regions of the keys.What is changed and how it works?
Proposal: xxx
What's Changed:
RangeKey
to remove confusing z-prefixed keys inRegionInfoProvider
gc_keys
handle_get_regions_in_range
logicRelated changes
Check List
Tests
Before
After
Release note