Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sst_importer: skip validation in ingest temporary (#7415) #7419

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 10, 2020

cherry-pick #7415 to release-3.1


What problem does this PR solve?

Issue Number: close pingcap/br#163

Problem Summary:

  • when we perform rewrite in download sst, the length of sstMeta will change, so it will cause panic in next vaildation.

What is changed and how it works?

This PR skip validation before ingest sst, so we can avoid panic since file length doesn't match.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

bugfixes: Fix the issue that generate lots of empty region after restore.

… sst file size correctly

Signed-off-by: luancheng <luancheng@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 10, 2020

/run-all-tests

@sre-bot sre-bot added component/backup-restore Component: backup, import, external_storage priority/release-blocker This issue blocks a release. Please solve it ASAP. type/cherry-pick Type: PR - Cherry pick labels Apr 10, 2020
@overvenus overvenus added this to the v3.1.0-ga milestone Apr 10, 2020
@youjiali1995 youjiali1995 merged commit 2f60853 into tikv:release-3.1 Apr 10, 2020
solotzg pushed a commit to pingcap/tidb-engine-ext that referenced this pull request Apr 15, 2020
… sst file size correctly (tikv#7419)

Signed-off-by: luancheng <luancheng@pingcap.com>
solotzg added a commit to pingcap/tidb-engine-ext that referenced this pull request Apr 15, 2020
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>

Cherry-pick 3.1:  adjust memory/CPU configurations automatically in container (tikv#7224)

tidb_query: fix TopN comparison for release 3.1 (tikv#7199)

Signed-off-by: zhongzc <zhongzc_arch@outlook.com>

Makefile: allow verbose warnings (tikv#7226)

Signed-off-by: Neil Shen <overvenus@gmail.com>

sst_importer: add error field to DownloadResponse (tikv#7271)

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

raftstore: fix a panic about read index during transfer leader (tikv#7101) (tikv#7240)

Signed-off-by: qupeng <qupeng@pingcap.com>

raftstore: apply read after snapshot (tikv#7230) (tikv#7249)

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

Rollup of backup commits (tikv#7297)

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: yiwu-arbug <yiwu@pingcap.com>
Signed-off-by: kennytm <kennytm@gmail.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>

Migrate Check-CN and Reloading Certs (tikv#7305)

Signed-off-by: Xintao <hunterlxt@live.com>
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>

coprocessor: differentiate real/int/decimal for `not` expressio… (tikv#7326)

Signed-off-by: Kenan Yao <cauchy1992@gmail.com>

*: bump v3.1.0-rc (tikv#7352)

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>

txn: write protected rollback when cleanup with missing lock (tikv#7365) (tikv#7389)

Signed-off-by: Yilin Chen <sticnarf@gmail.com>

 raftstore: tolerate out of order read index responses (tikv#7313) (tikv#7369)

Signed-off-by: qupeng <qupeng@pingcap.com>

sst_importer: skip validation in ingest temporary until we can handle sst file size correctly (tikv#7419)

Signed-off-by: luancheng <luancheng@pingcap.com>

raftstore: set term in read index response (tikv#7418)

Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/backup-restore Component: backup, import, external_storage priority/release-blocker This issue blocks a release. Please solve it ASAP. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants