Improve robustness of Backup/Restore involving external_storage (#7917) #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/backup-restore
5kbpers
approved these changes
May 29, 2020
|
Please fix conflicts |
kennytm
force-pushed
the
release-3.1-3c667df06126
branch
3 times, most recently
from
7750c03
to
6559431
Compare
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
release-3.1-3c667df06126
branch
from
6559431
to
1a39666
Compare
|
/run-integration-ddl-test /run-integration-compatibility-test |
overvenus
approved these changes
May 29, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-integration-ddl-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #7917 to release-3.1
What problem does this PR solve?
Issue Number: close #7375, close #7850, close #7880, close tidb-challenge-program/bug-hunting-issue#72
Problem Summary:
The backup/restore did not have timeout and retry. This causes a single spurious network error to either catastrophically kill the entire BR task or block the BR thread pool forever.
What is changed and how it works?
What's Changed:
ExternalStorage::writein particular) to fix AWS br backup failed when collation is open #7850.tame-gcsdoes not support resumable upload Support resumable upload EmbarkStudios/tame-gcs#24 so this won't work for GCS. (This also fix external_storage: if S3 upload cannot finish within 15 minutes it will fail #7375.)reqwestbyhyperso thoseconvert_requestandconvert_responseare no longer needed.ExternalStorage::read, so that a stuck download won't block the thread pool forever, to fix After backup/restore stuck, new backup cannot work until all tikv are deleted #7880.Related changes
Check List
Tests
minioS3 storage.Side effects
Release note