txn: check data constraint after lock #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
approved these changes
Nov 2, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/merge |
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
youjiali1995
force-pushed
the
cherry-pick-8921-to-3
branch
from
234e598 to
c08c7ca
Compare
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
/merge |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
ti-srebot
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Problem Summary:
Should check data constraint when no lock exists, otherwise it can report an error when there is a lock belonging to a committed transaction which deletes the key.
What is changed and how it works?
Cherry pick #8921 to release-3.0
Proposal: xxx
What's Changed:
Change the order between checking data constraint and lock.
Related changes
Check List
Tests
Release note