Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seta 2 Bankswitch support #1022

Merged
merged 16 commits into from
Aug 30, 2023
Merged

Add Seta 2 Bankswitch support #1022

merged 16 commits into from
Aug 30, 2023

Conversation

cam900
Copy link
Collaborator

@cam900 cam900 commented Mar 11, 2023

Sample memory is 1 MiB (non-bankswitched) or 16 MiB (bankswitched, maximum allowed in furnace).
Each bank area is 128 KiB. Bank slot is selectable in instrument editor.

src/engine/platform/x1_010.cpp Outdated Show resolved Hide resolved
@tildearrow
Copy link
Owner

Question: is that the only change required to enable bank-switching?

@cam900
Copy link
Collaborator Author

cam900 commented Apr 19, 2023

Question: is that the only change required to enable bank-switching?

Core bankswitching feature is written previously; so yes.

@freq-mod
Copy link
Collaborator

is that still being considered or stall?

@cam900 cam900 marked this pull request as ready for review July 26, 2023 10:39
src/engine/platform/x1_010.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@tildearrow tildearrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this will need some fixes, but I am going to merge it for now.

@tildearrow tildearrow merged commit ff3cebf into master Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants