Update argument handling #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
approved these changes
Apr 29, 2020
|
@cibernox that's the plan! I think it just so happens that no one has the cycle to work on the actual implementation yet, probably partly due to this polyfill being good enough, so I guess that's somewhat my fault :P |
chancancode
force-pushed
the
arguments-handling
branch
2 times, most recently
from
373cf3a
to
1b1a2ca
Compare
chancancode
commented
Apr 29, 2020
chancancode
force-pushed
the
arguments-handling
branch
3 times, most recently
from
c69dd03
to
76e1737
Compare
chancancode
commented
Apr 30, 2020
chancancode
force-pushed
the
arguments-handling
branch
5 times, most recently
from
28fcb78
to
b0b3a9b
Compare
This commit updates the argument handling: * To match [RFC PR #620](emberjs/rfcs#620) * Returns `null` on `null` or `undefined` * Use development mode assertions for other invalid arguments * Add test for modifiers usage * Add test for `...attributes` usage * To match more closely the likely Ember side implementation * Handle argument errors at runtime * `owner.hasRegistration('helper:element') === true` Since the argument errors are moved to runtime, this also removes the need for separate node tests. Previously, that also caused an error when `ember-auto-import` is included. Since we removed the `qunit` dependency we can now include `ember-auto-import` to align with the default addon blueprint. See also https://discordapp.com/channels/480462759797063690/485447409296736276/704799818316251216 Closes #6
chancancode
force-pushed
the
arguments-handling
branch
from
b0b3a9b
to
4841ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the argument handling:
nullonnullorundefined...attributesusageowner.hasRegistration('helper:element') === trueSince the argument errors are moved to runtime, this also removes the need for separate node tests. Previously, that also caused an error when
ember-auto-importis included. Since we removed thequnitdependency we can now includeember-auto-importto align with the default addon blueprint.See also https://discordapp.com/channels/480462759797063690/485447409296736276/704799818316251216