Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onerror is now provided (via 2nd arg) the promises label #404

Merged
merged 1 commit into from
Aug 28, 2015

Conversation

stefanpenner
Copy link
Collaborator

No description provided.

@@ -175,6 +175,20 @@ RSVP.on('error', function(reason) {
});
```

`RSVP` allows Promises to be labeled: `Promise.resovle(value, 'I AM A LABEL')`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/resovle/resolve

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teddyzeenny
Copy link
Contributor

👍

stefanpenner added a commit that referenced this pull request Aug 28, 2015
onerror is now provided (via 2nd arg) the promises label
@stefanpenner stefanpenner merged commit 7684756 into master Aug 28, 2015
@stefanpenner stefanpenner deleted the onerror-label branch August 28, 2015 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants