Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for piste routes #98

Merged
merged 2 commits into from
Dec 4, 2015
Merged

Conversation

zerebubuth
Copy link
Member

This adds processing for giving a kind to piste routes, and a post-process filter for removing routes tagged as abandoned.

Connects to tilezen/vector-datasource#342.

@rmarianski could you review, please?

@rmarianski
Copy link
Member

👍

I wonder if it makes sense to add support to the individual transforms/filters themselves to signal that a feature should be dropped, eg returning None for the shape. I almost added this for something in the past, but it got implemented in a different way so I never added support for it.

zerebubuth added a commit that referenced this pull request Dec 4, 2015
@zerebubuth zerebubuth merged commit caa3d4b into integration-1 Dec 4, 2015
@zerebubuth zerebubuth deleted the 342-add-piste-routes branch December 4, 2015 19:01
@zerebubuth
Copy link
Member Author

Yeah, I think it makes sense to do that - we've got more than one filter now which is about dropping certain features. It's pretty easy to do with the post-processor, but I always feel like that's a pretty "heavyweight" solution to a "lightweight" problem.

@rmarianski
Copy link
Member

I made a new issue to capture this: #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants