Fix unicode handling for property keys, layer names. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure we shouldn't have
unicodevalues for property keys or layer names, but looks like some slipped in somewhere and we're getting errors. This patch just makes sure that anywhere we're expecting a string we can also handleunicodeby converting to UTF-8.Also changes the test suite to be based on
unittest, although it still only checks that the output is generated without error and the resulting tile is truthy. See #3 for future work on making the tests do more useful stuff, such as checking the content of the tiles.Also adds a CircleCI config.