Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate protobuf python file #119

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Regenerate protobuf python file #119

merged 1 commit into from
Dec 21, 2022

Conversation

benoit9126
Copy link
Contributor

@benoit9126 benoit9126 commented Dec 20, 2022 •
edited
Loading

In order to solve #113 and following the original #114:

  • the protobuf version is modified to be greater or equal than 4.21. in the requirements
  • I realized that the proto file from Mapbox change a little (the package name only, see here) so I applied this change.
  • The Python code from the protobuf file definition has been regenerated.
  • The README is updated to explain how to compile the Python code from the protobuf definition file

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 77.038% when pulling 43a3b3c on benoit9126:protobuf into 3e8c662 on tilezen:master.

@rmarianski rmarianski merged commit d897587 into tilezen:master Dec 21, 2022
@benoit9126 benoit9126 deleted the protobuf branch December 21, 2022 09:07
@benoit9126 benoit9126 mentioned this pull request Dec 21, 2022
Closed
@vincentsarago vincentsarago mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit9126 @coveralls @rmarianski