Remove my postgres connection pools #149
Conversation
| self.sql_conn_pool = DatabaseCycleConnectionPool( | ||
| n_conn, max_conn, self.dbnames, self.conn_info) | ||
| self.sql_conn_pool = DBAffinityConnectionsNoLimit( | ||
| self.dbnames, self.conn_info) |
There was a problem hiding this comment.
This section around line 160 used to read:
self.sql_conn_pool = DBAffinityConnectionsNoLimit(
self.dbnames, n_conn, self.conn_info)
Where self.n_conn = n_conn was part of the function arguments.
Similarly on 170 we used to say:
sql_conns, conn_info = self.sql_conn_pool.get_conns()
instead of proposed:
sql_conns = self.sql_conn_pool.get_conns(self.n_conn)
There was a problem hiding this comment.
Yep, that was fairly messy, so this is a cleanup of that.
| import ujson | ||
|
|
||
|
|
||
| class DBAffinityConnectionsNoLimit(object): |
There was a problem hiding this comment.
Looking back at history I was expecting to see 3x as much content here, mostly based off this SHA:
And then bringing some of the hstore / ujson changes in from:
There was a problem hiding this comment.
We didn't use the other database pools, so I removed them.
The ujson stuff is there. The globally=True thing I wanted to leave off in case it caused the connection problem.
| @@ -533,7 +533,7 @@ def tilequeue_process(cfg, peripherals): | |||
| io_pool = ThreadPool(n_io_workers) | |||
|
|
|||
| feature_fetcher = DataFetcher(cfg.postgresql_conn_info, all_layer_data, | |||
| io_pool, n_layers, n_total_needed_query) | |||
| io_pool, n_layers) | |||
|
@zerebubuth for more substantive comments. |
|
@iandees Can you cleanup the merge conflict, please? |
|
🤔 I did, but the commit's not showing up ... I re-pushed it just now and I see it showed up. |
|
I'm going to go ahead and merge this per the tiles catchup meeting today. |
Backs out the connection pool bits of #145 (because they didn't work in production), puts back the existing
DBAffinityConnectionsNoLimitimplementation and adds the one-liner to useujson.loadsforregister_json().