Return a better error for invalid dates #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zerebubuth, @iandees can you review please? |
zerebubuth
requested changes
Feb 13, 2017
tilequeue/wof.py
Outdated
| cessation_latest = edtf_cessation.date_latest() | ||
| deprecated_latest = edtf_deprecated.date_latest() | ||
| if inception_earliest is None: | ||
| return failure('invalid edtf:inception: %s' % props['edtf:inception']) |
There was a problem hiding this comment.
It's possible for props not to have an edtf:... key, which is hidden by _normalize_edtf returning a valid EDTF object when given None. This might cause a KeyError here, though?
Perhaps failure('invalid edtf:inception: %r' % props.get('edtf:inception'))?
There was a problem hiding this comment.
Well spotted! Fixed in f133a5d.
iandees
approved these changes
Feb 13, 2017
zerebubuth
approved these changes
Feb 13, 2017
rmarianski
force-pushed
the
wof-better-failure-invalid-date
branch
from
f133a5d
to
0cbd908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we get invalid dates, we can have the edtf date api return back
Nonefor earliest/latest dates. This adds a check to guard against that, and return back a better error message in this case. Otherwise, theminor something else downstream will raise a general error when it's first used.