Trap MemoryError, print a log message, and halt #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MemoryError sometimes gets thrown when a very, very large message is put in a multiprocessing queue. This exception propagates up to the root of the thread and kills it, locking up the worker. According to the Python docs, MemoryError isn't entirely safe to recover from, so instead this halts the whole process. It will be restarted by runit / systemd, and it might lose some work, but any lost jobs will be re-queued by SQS after a timeout.
iandees
approved these changes
Mar 20, 2017
rmarianski
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryError sometimes gets thrown when a very, very large message is put in a multiprocessing queue. This exception propagates up to the root of the thread and kills it, locking up the worker.
According to the Python docs, MemoryError isn't entirely safe to recover from, so instead this halts the whole process. It will be restarted by runit / systemd, and it might lose some work, but any lost jobs will be re-queued by SQS after a timeout.