Add the ability to list individual tiles that should stay in the TOI #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample config: toi-prune:
redshift-uri: postgresql://redacted:redacted@localhost:5439/analytics
days: 30
s3:
bucket: mapzen-tiles-dev-us-east
date-prefix: 20170123
path: osm
layer: all
format: zip
always-include:
conus:
bbox: -124.8,24.8,-66.1,49.3
min_zoom: 10
max_zoom: 13
world:
bbox: -180.0,-85.06,180.0,85.06
min_zoom: 0
max_zoom: 9
tests:
tiles: [5/2/4, 5/7/8] |
|
Nice! |
rmarianski
approved these changes
Mar 28, 2017
| elif 'tiles' in info: | ||
| tiles = map(deserialize_coord, info['tiles']) | ||
| tiles = map(coord_marshall_int, tiles) | ||
| immortal_tiles.update(tiles) |
There was a problem hiding this comment.
Can I make a feature request? :) How about adding something like path or file(s). We would expect that the file contains coordinates, one per line.
I'm expecting that when we add the tests, what we'll do is first run the script that prints them out. And then we can save that to a file and feed it into this. Maybe another option is to read it from stdin to avoid having the temporary file?
|
Is there an assumption that the list of tiles is always 512px (2x2)
metatile size?
…On Wed, Mar 29, 2017 at 2:30 PM, Ian Dees ***@***.***> wrote:
Merged #178 <#178>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#178 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0EOwocAXfINL90x7DCxse2TuSWKdPuks5rqs2CgaJpZM4MrANT>
.
|
|
Yea, good point. The tiles at this point are dumped straight into the TOI so they are assumed to be 512px. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #176, adds the ability to list individual tiles that should stay in the TOI