Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the zoom to enqueue to 15 #181

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Move the zoom to enqueue to 15 #181

merged 3 commits into from
Apr 13, 2017

Conversation

rmarianski
Copy link
Member

This gets run when enqueueing the tiles of interest, when we deploy to prod and enqueue all the tiles. This should be set to z15 now.

This wasn't changing really changing before, but maybe this should be set from configuration now? Or perhaps we do it next time if/when this changes?

@zerebubuth
Copy link
Member

👍 for making this configurable, too.

@rmarianski
Copy link
Member Author

Made the zoom to enqueue configurable in c6bf885. But in the future, we might want to see if we can merge it in together with

max_zoom = 16 - self.metatile_zoom
. At that point, maybe it should really be set to 16, and we subtract away the metatile zoom just like that code in the worker does?

@zerebubuth
Copy link
Member

At that point, maybe it should really be set to 16, and we subtract away the metatile zoom just like that code in the worker does?

Yup, exactly. That way we could change the metatile zoom without having to remember that it's coupled to the max zoom.

@rmarianski
Copy link
Member Author

rmarianski commented Apr 5, 2017

At that point, maybe it should really be set to 16, and we subtract away the metatile zoom just like that code in the worker does?

Yup, exactly. That way we could change the metatile zoom without having to remember that it's coupled to the max zoom.

Updated in cb38515.

@rmarianski rmarianski merged commit 02203f7 into master Apr 13, 2017
@rmarianski rmarianski deleted the move-enqueue-z15 branch April 13, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants