A couple cleanups from running the gardener locally #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Have to include tilesize in the redshift group by query - Filter out null tile coords that might sneak in to the immortal tiles section - The redis client expects srem args to be a star-arg, not a list
rmarianski
approved these changes
Apr 6, 2017
tilequeue/cache/redis_cache_index.py
Outdated
| @@ -18,7 +18,7 @@ def intersect(self, coords, tiles_of_interest=None): | |||
| yield coord | |||
|
|
|||
| def remove_tiles_of_interest(self, coord_ints): | |||
| return self.redis_client.srem(self.cache_set_key, coord_ints) | |||
| return self.redis_client.srem(self.cache_set_key, *coord_ints) | |||
There was a problem hiding this comment.
Nice catch! ⚡
This will turn into a single call to redis, so we probably shouldn't call this with millions of integers. (Not sure if we are or aren't, just caught my eye).
There was a problem hiding this comment.
It's currently getting called in groups of 1000. It's probably a good thing to document, though.
There was a problem hiding this comment.
👍 I was just lazy and didn't check :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple cleanups from #180.